Merged
Conversation
…and roadmap in README with accompanying images.
…for stances, and update default stance configurations.
Contributor
Qodana Community for JVM4 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2025.1.1
with:
upload-result: trueContact Qodana teamContact us at qodana-support@jetbrains.com
|
…nd correctly restore active stance by ID after modifications.
…gs, including handling empty stance lists.
…d update default LLM models.
…ple and modify `TerminalService.kt`.
…including `encryptedKey` support and a global `settingsEditable` flag.
…les via `ronin-profile.json`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several significant updates to the Ronin IntelliJ plugin, focusing on improved configuration management, enhanced command execution, and overall codebase simplification. The most notable changes include the removal of the
RoninConfigService, expanded support for stance configuration (including execution commands and descriptions), enhancements to the shell command execution logic, and improvements to the LLM service's prompt construction and credential handling.Configuration and Stance Management Improvements:
RoninConfigServiceand all related project context/rules logic, simplifying how file and context information is gathered throughout the plugin. (src/main/kotlin/com/ronin/service/RoninConfigService.kt[1]src/main/kotlin/com/ronin/actions/BaseRoninAction.kt[2]src/main/kotlin/com/ronin/service/LLMService.kt[3]src/main/kotlin/com/ronin/settings/RoninSettingsConfigurable.kt[1] [2] [3] [4] [5]Shell Command Execution Enhancements:
TerminalServiceto use the user's preferred shell (with fallbacks), run in interactive/login mode, and handle environment variables more robustly. Added better process interruption and error handling. (src/main/kotlin/com/ronin/service/TerminalService.ktsrc/main/kotlin/com/ronin/service/TerminalService.ktL14-R63)LLM Service and Prompt Construction:
src/main/kotlin/com/ronin/service/LLMService.kt[1] [2]src/main/kotlin/com/ronin/service/LLMService.ktsrc/main/kotlin/com/ronin/service/LLMService.ktL116-R124)General Codebase Maintenance:
gradle.propertiesgradle.propertiesL7-R7)EditServiceand improved JSON model parsing inLLMService. (src/main/kotlin/com/ronin/service/EditService.kt[1] [2]src/main/kotlin/com/ronin/service/LLMService.kt[3]These changes collectively improve the plugin's configurability, reliability, and maintainability.