Add function to check connection state, handle goodbye and disconnect callback - #34
Merged
Merged
Conversation
Mahad-10
marked this pull request as draft
October 9, 2025 15:03
Mahad-10
force-pushed
the
connected-function-disconnect-callback
branch
3 times, most recently
from
October 10, 2025 11:35
a032dbd to
551bf42
Compare
Mahad-10
marked this pull request as ready for review
October 10, 2025 12:08
Mahad-10
force-pushed
the
connected-function-disconnect-callback
branch
4 times, most recently
from
October 13, 2025 14:16
227d53b to
075e385
Compare
om26er
reviewed
Oct 24, 2025
| })(); | ||
| } | ||
|
|
||
| setDisconnectCallback(callback: () => Promise<void>): void { |
Member
There was a problem hiding this comment.
Suggested change
| setDisconnectCallback(callback: () => Promise<void>): void { | |
| onDisconnect(callback: () => Promise<void>): void { |
Member
|
please rebase |
Mahad-10
force-pushed
the
connected-function-disconnect-callback
branch
2 times, most recently
from
October 27, 2025 07:40
6323682 to
8ccda3d
Compare
Mahad-10
force-pushed
the
connected-function-disconnect-callback
branch
from
October 27, 2025 10:57
8ccda3d to
41d64ea
Compare
Mahad-10
force-pushed
the
connected-function-disconnect-callback
branch
from
October 27, 2025 10:59
41d64ea to
47622c0
Compare
om26er
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.