Disable VGA device at all when vga=none#14
Open
timemaster5 wants to merge 1 commit intoxcp-ng:masterfrom
Open
Conversation
Currently when VGA is turned of in XO or by hand setup as vga=none the -device VGA gets replaced with -device cirrus-vga Signed-off-by: timemaster5 <timemaster@trillinis.com>
timemaster5
force-pushed
the
vga-none-fix
branch
from
9e44484 to
ff2736d
Compare
last-genius
reviewed
Mar 23, 2026
|
|
||
| n += 1 | ||
|
|
||
| if vga_type == 'vgpu': |
There was a problem hiding this comment.
We are not going to break compatibility by changing the meaning of none here.
passthrough GPUs should already be handled by overriding vga_type in xenopsd. how did you set up passthrough in xapi?
Member
There was a problem hiding this comment.
What is the actual meaning of vga=none ? I can't find none as a "video card" kind (in xenops types).
Xen Orchestra consider disabling VGA as "use Cirrus".
I think the user is looking for a equivalent of vga = "none" of xl, which is basically skip adding a emulated VGA device in the guest (which is not the same as using QEMU stdvga, no vga would lead to no display of course).
That could help forcing a passed-through GPU being the primary one (by being the only one).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When VGA is turned off in XO or manually set up as vga=none, the -device VGA is replaced with -device cirrus-vga.
This is a fix for qemu-wrapper that omits any VGA device when vga=none.