[XEN-3146] Upgrade to AWS SDK 2.x#43
Merged
Merged
Conversation
pvriel
reviewed
Nov 6, 2025
pvriel
reviewed
Nov 6, 2025
pvriel
reviewed
Nov 6, 2025
pvriel
reviewed
Nov 6, 2025
pvriel
reviewed
Nov 6, 2025
pvriel
requested changes
Nov 6, 2025
pvriel
left a comment
pvriel
left a comment
There was a problem hiding this comment.
Please take a look at the comments I left behind. Nothing major, though ;)
pvriel
approved these changes
Nov 7, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the AWS SDK from version 1.x to version 2.x, addressing the obsolescence of SDK 1.x. The migration involves updating API calls, exception handling, and request/response patterns throughout the codebase to align with SDK 2.x conventions.
Key changes:
- Updated all AWS SDK imports from
com.amazonaws.*tosoftware.amazon.awssdk.* - Migrated from imperative API style to builder patterns for all S3 operations
- Replaced manual pagination with SDK 2.x paginator utilities
- Implemented custom progress tracking for multipart uploads
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| S3StorageClient.java | Core migration of S3 client initialization and all S3 operations to SDK 2.x APIs |
| S3OutputStream.java | Updated multipart upload implementation with SDK 2.x request/response patterns |
| S3BackupRepositoryConfig.java | Added new configuration properties and updated client builder integration |
| S3BackupRepository.java | Added URISyntaxException handling for client initialization |
| ProgressTrackingInputStream.java | New custom implementation to track upload progress |
| build.gradle files | Updated dependencies from AWS SDK 1.x BOM to 2.x BOM |
| solr.xml | Added new configuration properties for checksum validation and progress logging |
| docker-compose.yml | Added volume mount options and new environment variable |
| SolrBackupTest.java | Migrated test S3 client initialization to SDK 2.x |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AWS SDK 1.x is obsolete. This PR ports the implementation to version 2.x. Updated methods are annotated with a comment to explain the change in migration, these can be removed later if needed.