Integrate optional plotting capabilities into ashist()#636
Open
willcollins10 wants to merge 3 commits into
Open
Integrate optional plotting capabilities into ashist()#636willcollins10 wants to merge 3 commits into
willcollins10 wants to merge 3 commits into
Conversation
Collaborator
|
@willcollins10 --- thanks for the PR! I will try to take a look this afternoon! |
Collaborator
|
@willcollins10 --- side note, the tests fail because the example you added in the docstring never defines |
nwlandry
requested changes
Dec 10, 2024
nwlandry
left a comment
Collaborator
There was a problem hiding this comment.
Overall looks awesome! Three main comments: (1) move the plotting contents to a helper function and (2) add the ability to plot a scatterplot, and (3) fix the docstring so that the doctests pass. Thanks for the contribution!
3cab05e to
1015af0
Compare
…octest Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
cf6305a to
b0e955d
Compare
Collaborator
|
@nwlandry I think I addressed your comments, if you're happy we can close. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR integrates optional plotting capabilities directly into the
ashist()function. Users can now generate plots ('bar','line', or'step') by setting theplotparameter toTrueand customize plot appearance usingplot_kwargs.Changes Made
plotandplot_kwargsparameters to theashist()function.matplotlib.pyplotbased on the specified plot type.bin_edgesisTrue.Testing
plot_kwargs.densityandbin_edges.Related Issues
Closes #<606>