Optimize line graph construction#706
Merged
Merged
Conversation
kaiser-dan
approved these changes
Apr 5, 2026
kaiser-dan
left a comment
kaiser-dan
left a comment
Collaborator
There was a problem hiding this comment.
Hey @Ved235 , thanks for this work! It is a welcome change with some impressive speedups.
I've looked through the code and it seems straight-forward enough, I'll approve the PR now but merge it into the dev branch instead later.
Collaborator
|
@kaiser-dan --- is there a timeline for this being merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the implementation in
xgi.convert.to_line_graph()to avoid scanning every pair of hyperedges. Instead of usingcombinations(H._edge, 2)and checking every pair, it now only considers pairs that actually overlap.On synthetic hypergraphs generated using codex, there was a significant performance gain:
2k:436.47 ms->25.54 ms4k:1936.89 ms->98.47 ms6k:4975.49 ms->219.49 msValidation
pytest -q 392 passed, 6 skipped, 117 warnings in 17.99s