fix: validate backend user and userGroups access in NewsRepository

[konradmichalik]

• Add proper validation that BE_USER global exists and is object
• Validate userGroups property exists and is array before accessing
• Use method_exists() to safely check for isAdmin() method
• Return empty array instead of potential errors for invalid user states
• Prevent potential security issues from accessing undefined properties

Summary by CodeRabbit

• Bug Fixes
  • Improved error handling to prevent issues when user information is missing or incomplete during news retrieval.

[coderabbitai]

Walkthrough

The method findAllByCurrentUser in the NewsRepository class was updated to introduce validation checks for the global backend user object. The code now ensures $GLOBALS['BE_USER'] is set and is an object before proceeding. It also checks that the userGroups property exists and is an array. Additionally, before calling the isAdmin method, the code verifies that this method exists on the backend user object. The remainder of the method, including cache handling and query logic, remains unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d446f45 and a826582.

📒 Files selected for processing (1)

• Classes/Domain/Repository/NewsRepository.php (1 hunks)

🔇 Additional comments (5)

Classes/Domain/Repository/NewsRepository.php (5)

44-47: Excellent defensive programming practice.

The validation ensures $GLOBALS['BE_USER'] exists and is an object before proceeding, preventing potential errors from accessing undefined or invalid backend user state. The early return with an empty array is appropriate for handling invalid user states.

---

49-49: Good practice using a local variable.

Assigning the validated global to a local variable improves readability and reduces repeated global access. This makes the code more maintainable and testable.

---

51-54: Proper validation of userGroups property.

The dual validation ensures both the existence of the userGroups property and that it's an array before attempting to use it. This prevents potential errors when the property is missing or has an unexpected type.

---

56-56: Consistent usage of validated backend user.

Using the validated $backendUser->userGroups is consistent with the validation checks above and ensures safe access to the property.

---

62-63: Safe method call with existence check.

Using method_exists() before calling isAdmin() prevents potential errors if the method doesn't exist on the backend user object. This is particularly important for compatibility across different TYPO3 versions or configurations.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch validate-usergroup-access

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coveralls]

Pull Request Test Coverage Report for Build 16652564270

Details

• 0 of 7 (0.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.6%) to 41.543%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
Classes/Domain/Repository/NewsRepository.php	0	7	0.0%

Totals
Change from base Build 16649970950:	-0.6%
Covered Lines:	140
Relevant Lines:	337

---

💛 - Coveralls