Skip to content

feat: redesign internal news backend UI and add news list modal - #53

Merged
konradmichalik merged 7 commits into
mainfrom
feature/internal-news-backend-ui
Jun 26, 2026
Merged

feat: redesign internal news backend UI and add news list modal#53
konradmichalik merged 7 commits into
mainfrom
feature/internal-news-backend-ui

Conversation

@konradmichalik

@konradmichalik konradmichalik commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Redesign the backend appearance of the dashboard widget, toolbar dropdown and news detail modal (TYPO3-native, theme-safe for light/dark)
  • Add a "Show all news" entry in the toolbar dropdown that opens the full, user-filtered news list as a modal — usable even when no dashboard widget is set up
  • Fix the news modal sizing: it now grows with its content (fit-content) instead of forcing a fixed large height that left a large empty area
  • Make detail-modal media responsive (no more hardcoded 760px widths)
  • Fix the dashboard widget "List" button on TYPO3 v14 (was redirecting to the dashboard instead of the record list)
  • Store the news description as TEXT so longer rich-text content no longer hits the varchar(2000) limit
  • Drop the dashboard reference in the dropdown intro text, pointing at the new "Show all news" action instead
  • Extract a shared NewsList partial to remove duplication across the three news-list renderings

Changes

  • Resources/Public/Stylesheets/Backend.css - Refined card/list/modal styling, list-modal and dropdown-footer styles
  • Resources/Public/JavaScript/utils.js - Content-fit modal size, fetchNewsList() + list modal, shared close button
  • Resources/Public/JavaScript/toolbar.js - Bind the "Show all news" trigger
  • Resources/Private/Partials/NewsList.html - New shared list partial (used by widget, dropdown, list modal)
  • Resources/Private/Partials/Detail.html - Content wrapper + responsive media
  • Resources/Private/Templates/Default/List.html - New template for the list modal
  • Resources/Private/Templates/Backend/Widgets/List.html - Use shared NewsList partial
  • Resources/Private/Templates/Backend/ToolbarItems/NewsItemDropDown.html - "Show all news" footer button, updated intro, use shared partial
  • Classes/Controller/DateController.php - listAction rendering the user-filtered news list
  • Configuration/Backend/AjaxRoutes.php - internal_news_list route
  • Classes/Widgets/Provider/ListInternalNewsButtonProvider.php - Version-correct list module route identifier (v14 records, v13 web_list)
  • ext_tables.sql / Configuration/TCA/...news.php - description column to TEXT, drop the max cap
  • Resources/Private/Language/*.locallang.xlf - toolbaritem.showAll label, reworded intro text
  • Resources/Public/Icons/news.svg, news-color.svg - Updated toolbar icons
  • Tests/Acceptance/Fixtures/* - Example news item with an attached image (SQL + media-copy script + PNG)

Summary by CodeRabbit

  • New Features

    • Added a “show all news” view with a full list and empty-state message.
    • Introduced a list endpoint and updated the toolbar to open the complete news list.
    • Clicking items in the list now opens the detailed news view.
  • Bug Fixes

    • Improved media display sizing in news details.
    • Updated backend link handling for newer TYPO3 versions.
  • Style

    • Refreshed backend/news list styling for a cleaner, more consistent layout.

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@konradmichalik, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 46 minutes and 16 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 36819073-b343-4914-b09d-9749e69d5bc3

📥 Commits

Reviewing files that changed from the base of the PR and between fe95d24 and 780c461.

📒 Files selected for processing (2)
  • Resources/Public/Stylesheets/Backend.css
  • ext_tables.sql

Walkthrough

Adds a backend AJAX endpoint for listing internal news, updates toolbar and template rendering to use a shared list partial, adds JavaScript for opening the list modal and loading item details, adjusts backend styling and detail markup, and extends acceptance fixtures with a news item that includes media.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: a backend UI redesign with a new internal news list modal.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/internal-news-backend-ui

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coveralls

coveralls commented Jun 26, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 28238866047

Coverage decreased (-2.2%) to 76.178%

Details

  • Coverage decreased (-2.2%) from the base build.
  • Patch coverage: 11 uncovered changes across 1 file (2 of 13 lines covered, 15.38%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
Classes/Controller/DateController.php 11 0 0.0%
Total (2 files) 13 2 15.38%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 382
Covered Lines: 291
Line Coverage: 76.18%
Coverage Strength: 3.29 hits per line

💛 - Coveralls

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ext_tables.sql`:
- Line 11: Remove the literal default from the description TEXT column in
ext_tables.sql so the schema stays compatible across MySQL installs. Update the
CREATE/ALTER table definition for description to keep NOT NULL if needed, but
drop DEFAULT '' rather than changing other column behavior.

In `@Resources/Public/Stylesheets/Backend.css`:
- Around line 187-189: The bare small selector in Backend.css is affecting all
small elements globally instead of only internal-news content. Scope this rule
under the internal-news ancestor used in the stylesheet so the color override
applies only to the intended area, and keep the existing declaration inside that
more specific selector.
- Around line 7-12: The custom properties in Backend.css are scoped only to
:where(.internal-news, .internal-news-detail, .dropdown-headline), so
.internal-news--empty, .dropdown-item-text, and .internal-news--dropdown-footer
do not inherit them. Move the variable definitions out of that selector and onto
a stable shared ancestor such as body or :root so all consumers in
Default/List.html and NewsItemDropDown.html can resolve --in-border,
--in-hover-bg, --in-muted, and --in-accent correctly.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: dae0431e-5ab7-463c-a2ce-a61c651469c7

📥 Commits

Reviewing files that changed from the base of the PR and between b9dd606 and fe95d24.

⛔ Files ignored due to path filters (3)
  • Resources/Public/Icons/news-color.svg is excluded by !**/*.svg
  • Resources/Public/Icons/news.svg is excluded by !**/*.svg
  • Tests/Acceptance/Fixtures/files/internal-news-example.png is excluded by !**/*.png
📒 Files selected for processing (17)
  • Classes/Controller/DateController.php
  • Classes/Widgets/Provider/ListInternalNewsButtonProvider.php
  • Configuration/Backend/AjaxRoutes.php
  • Configuration/TCA/tx_ximatypo3internalnews_domain_model_news.php
  • Resources/Private/Language/de.locallang.xlf
  • Resources/Private/Language/locallang.xlf
  • Resources/Private/Partials/Detail.html
  • Resources/Private/Partials/NewsList.html
  • Resources/Private/Templates/Backend/ToolbarItems/NewsItemDropDown.html
  • Resources/Private/Templates/Backend/Widgets/List.html
  • Resources/Private/Templates/Default/List.html
  • Resources/Public/JavaScript/toolbar.js
  • Resources/Public/JavaScript/utils.js
  • Resources/Public/Stylesheets/Backend.css
  • Tests/Acceptance/Fixtures/internal-news-media.sh
  • Tests/Acceptance/Fixtures/internal-news.sql
  • ext_tables.sql
💤 Files with no reviewable changes (1)
  • Configuration/TCA/tx_ximatypo3internalnews_domain_model_news.php

Comment thread ext_tables.sql Outdated
Comment thread Resources/Public/Stylesheets/Backend.css Outdated
Comment thread Resources/Public/Stylesheets/Backend.css Outdated
@konradmichalik
konradmichalik merged commit ecdca18 into main Jun 26, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants