Skip to content

Show the PagerTabStripViewController with the selected sub-controller (default tab)#692

Open
bivant wants to merge 3 commits intoxmartlabs:masterfrom
bivant:originMaster
Open

Show the PagerTabStripViewController with the selected sub-controller (default tab)#692
bivant wants to merge 3 commits intoxmartlabs:masterfrom
bivant:originMaster

Conversation

@bivant
Copy link
Copy Markdown

@bivant bivant commented Mar 22, 2019

Solves the issue and another one

bivant referenced this pull request in Sepicat/XLPagerTabStrip Mar 22, 2019
Copy link
Copy Markdown

@alexookah alexookah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok

@alexookah
Copy link
Copy Markdown

alexookah commented May 10, 2019

@xmartlabs please merge this PL into master.

Test:
in viewDidLoad
moveToViewController(at: indexTo, animated: false)
super.viewDidLoad()

@bivant
Copy link
Copy Markdown
Author

bivant commented May 11, 2019

Hello @alexookah
Is it ok now or I messed it up? My update works as expected if I test with/without it the example app after the merge (critical to call moveToViewCmoveToViewController(at: indexTo, animated: false) before the super.viewDidLoad() )

@alexookah
Copy link
Copy Markdown

Hello @alexookah
Is it ok now or I messed it up? My update works as expected if I test with/without it the example app after the merge (critical to call moveToViewCmoveToViewController(at: indexTo, animated: false) before the super.viewDidLoad() )

it's ok. just added how to test it so that this get's merged into master.

Copy link
Copy Markdown

@zhpengkun zhpengkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me.

Copy link
Copy Markdown

@zhpengkun zhpengkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@zhpengkun
Copy link
Copy Markdown

@mtnbarreto Is this can be merged? Anyone?

@juanbiberretta
Copy link
Copy Markdown

Would love to see this merged! :D

@sroymeetup
Copy link
Copy Markdown

Would be nice to see this get merged! We have an issue in our app that depends on this fix.

@bivant
Copy link
Copy Markdown
Author

bivant commented Aug 13, 2019

Fix for another user case with sub-controllers switch #746 for anyone interested

Copy link
Copy Markdown

@ElonPark ElonPark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants