Skip to content

[do not merge] patch so XWing Obsolete has a valid code path#1

Open
insipx wants to merge 1 commit into
mainfrom
xmtp/xwing-obsolete-v0.6.1
Open

[do not merge] patch so XWing Obsolete has a valid code path#1
insipx wants to merge 1 commit into
mainfrom
xmtp/xwing-obsolete-v0.6.1

Conversation

@insipx

@insipx insipx commented May 21, 2026

Copy link
Copy Markdown

KEM math is identical between the two variants — only the codepoint mixed into HPKE suite_id labels (and thus AEAD keys) differs. Lets clients pin to the obsolete 0x004D codepoint for wire compat with peers on hpke-rs 0.4.x.

Based on v0.6.1.

can be deleted after d14n migration

Note

Add valid code path for KemAlgorithm::XWingDraft06Obsolete in libcrux provider

Routes KemAlgorithm::XWingDraft06Obsolete through the same logic as XWingDraft06 in kem_key_gen, supports_kem, and kem_key_type_to_libcrux_alg in lib.rs. Previously, this variant had no valid code path and would error. #[allow(deprecated)] is added to the relevant match arms to suppress deprecation warnings.

Macroscope summarized 3425025.

KEM math is identical between the two variants — only the codepoint
mixed into HPKE suite_id labels (and thus AEAD keys) differs. Lets
clients pin to the obsolete 0x004D codepoint for wire compat with
peers on hpke-rs 0.4.x.

Based on v0.6.1.
@macroscopeapp

macroscopeapp Bot commented May 21, 2026

Copy link
Copy Markdown

Approvability

Verdict: Approved

Mechanical fix adding the existing XWingDraft06Obsolete enum variant to match arms in libcrux_provider, mirroring the same pattern already used throughout the codebase. No new behavior introduced - just completing exhaustive pattern matching with identical handling.

You can customize Macroscope's approvability policy. Learn more.

@insipx insipx changed the title patch so XWing Obsolete has a valid code path [do not merge] patch so XWing Obsolete has a valid code path May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant