[do not merge] patch so XWing Obsolete has a valid code path#1
Open
insipx wants to merge 1 commit into
Open
Conversation
KEM math is identical between the two variants — only the codepoint mixed into HPKE suite_id labels (and thus AEAD keys) differs. Lets clients pin to the obsolete 0x004D codepoint for wire compat with peers on hpke-rs 0.4.x. Based on v0.6.1.
ApprovabilityVerdict: Approved Mechanical fix adding the existing You can customize Macroscope's approvability policy. Learn more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KEM math is identical between the two variants — only the codepoint mixed into HPKE suite_id labels (and thus AEAD keys) differs. Lets clients pin to the obsolete 0x004D codepoint for wire compat with peers on hpke-rs 0.4.x.
Based on v0.6.1.
can be deleted after d14n migration
Note
Add valid code path for
KemAlgorithm::XWingDraft06Obsoletein libcrux providerRoutes
KemAlgorithm::XWingDraft06Obsoletethrough the same logic asXWingDraft06inkem_key_gen,supports_kem, andkem_key_type_to_libcrux_algin lib.rs. Previously, this variant had no valid code path and would error.#[allow(deprecated)]is added to the relevant match arms to suppress deprecation warnings.Macroscope summarized 3425025.