Remove cursor support from SubscribeAllEnvelopes#326
Merged
Conversation
Contributor
ApprovabilityVerdict: Approved Simple proto schema change removing cursor support from You can customize Macroscope's approvability policy. Learn more. |
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
neekolas
approved these changes
Mar 10, 2026
Maelkum
changed the title
SubscribeAllEnvelopes
|
🎉 This PR is included in version 3.89.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned here the amount of data one could unintentionally stream is too large, so we're removing cursor support for "stream all".
Technically correct would be to have the
reserve 1;directive, but this change was not really released and no one really relies on it so no breaking changes should happen.Note
Remove
last_seencursor field fromSubscribeAllEnvelopesRequestRemoves the
last_seencursor field from theSubscribeAllEnvelopesRequestproto message in message_api.proto, leaving it empty. Risk: callers that set or readlast_seenwill break; serialized requests that previously included a cursor will now be empty.Macroscope summarized 21efdc8.