Skip to content

Fix emoji not rendering in table cells #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xoofx merged 3 commits into from
Mar 4, 2026
Merged

Fix emoji not rendering in table cells #928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b74788
Fix emoji not rendering in table cells
prozolic Mar 4, 2026
3cb3efd
Update EmojiSpecs.md
prozolic Mar 4, 2026
a6a118b
Update src/Markdig/Extensions/Emoji/EmojiParser.cs
prozolic Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 63 additions & 5 deletions src/Markdig.Tests/Specs/EmojiSpecs.generated.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@ public void ExtensionsEmoji_Example001()
// Should be rendered as:
// <p>This is a test with a 😃 and a 😠 smiley</p>

TestParser.TestSpec("This is a test with a :) and a :angry: smiley", "<p>This is a test with a 😃 and a 😠 smiley</p>", "emojis|advanced+emojis", context: "Example 1\nSection Extensions / Emoji\n");
TestParser.TestSpec("This is a test with a :) and a :angry: smiley", "<p>This is a test with a 😃 and a 😠 smiley</p>", "pipetables+emojis|advanced+emojis", context: "Example 1\nSection Extensions / Emoji\n");
}

// An emoji needs to be preceded by a space:
// An emoji must not be preceded by a letter or digit:
[Test]
public void ExtensionsEmoji_Example002()
{
Expand All @@ -46,7 +46,7 @@ public void ExtensionsEmoji_Example002()
// Should be rendered as:
// <p>These are not:) an emoji with a:) x:angry:x</p>

TestParser.TestSpec("These are not:) an emoji with a:) x:angry:x", "<p>These are not:) an emoji with a:) x:angry:x</p>", "emojis|advanced+emojis", context: "Example 2\nSection Extensions / Emoji\n");
TestParser.TestSpec("These are not:) an emoji with a:) x:angry:x", "<p>These are not:) an emoji with a:) x:angry:x</p>", "pipetables+emojis|advanced+emojis", context: "Example 2\nSection Extensions / Emoji\n");
}

// Emojis can be followed by close punctuation (or any other characters):
Expand All @@ -62,7 +62,7 @@ public void ExtensionsEmoji_Example003()
// Should be rendered as:
// <p>We all need 😃, it makes us 💪. (and 👌).</p>

TestParser.TestSpec("We all need :), it makes us :muscle:. (and :ok_hand:).", "<p>We all need 😃, it makes us 💪. (and 👌).</p>", "emojis|advanced+emojis", context: "Example 3\nSection Extensions / Emoji\n");
TestParser.TestSpec("We all need :), it makes us :muscle:. (and :ok_hand:).", "<p>We all need 😃, it makes us 💪. (and 👌).</p>", "pipetables+emojis|advanced+emojis", context: "Example 3\nSection Extensions / Emoji\n");
}

// Sentences can end with emojis:
Expand All @@ -80,7 +80,65 @@ public void ExtensionsEmoji_Example004()
// <p>This is a sentence 👌
// and keeps going to the next line 😃</p>

TestParser.TestSpec("This is a sentence :ok_hand:\nand keeps going to the next line :)", "<p>This is a sentence 👌\nand keeps going to the next line 😃</p>", "emojis|advanced+emojis", context: "Example 4\nSection Extensions / Emoji\n");
TestParser.TestSpec("This is a sentence :ok_hand:\nand keeps going to the next line :)", "<p>This is a sentence 👌\nand keeps going to the next line 😃</p>", "pipetables+emojis|advanced+emojis", context: "Example 4\nSection Extensions / Emoji\n");
}

// Emojis are rendered inside pipe table cells with surrounding spaces:
[Test]
public void ExtensionsEmoji_Example005()
{
// Example 5
// Section: Extensions / Emoji
//
// The following Markdown:
// | header |
// |--------|
// | :x: |
//
// Should be rendered as:
// <table>
// <thead>
// <tr>
// <th>header</th>
// </tr>
// </thead>
// <tbody>
// <tr>
// <td>❌</td>
// </tr>
// </tbody>
// </table>

TestParser.TestSpec("| header |\n|--------|\n| :x: |", "<table>\n<thead>\n<tr>\n<th>header</th>\n</tr>\n</thead>\n<tbody>\n<tr>\n<td>❌</td>\n</tr>\n</tbody>\n</table>", "pipetables+emojis|advanced+emojis", context: "Example 5\nSection Extensions / Emoji\n");
}

// Emojis are rendered inside pipe table cells without surrounding spaces:
[Test]
public void ExtensionsEmoji_Example006()
{
// Example 6
// Section: Extensions / Emoji
//
// The following Markdown:
// | header |
// |--------|
// |:x:|
//
// Should be rendered as:
// <table>
// <thead>
// <tr>
// <th>header</th>
// </tr>
// </thead>
// <tbody>
// <tr>
// <td>❌</td>
// </tr>
// </tbody>
// </table>

TestParser.TestSpec("| header |\n|--------|\n|:x:|", "<table>\n<thead>\n<tr>\n<th>header</th>\n</tr>\n</thead>\n<tbody>\n<tr>\n<td>❌</td>\n</tr>\n</tbody>\n</table>", "pipetables+emojis|advanced+emojis", context: "Example 6\nSection Extensions / Emoji\n");
}
}
}
44 changes: 43 additions & 1 deletion src/Markdig.Tests/Specs/EmojiSpecs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ This is a test with a :) and a :angry: smiley
<p>This is a test with a 😃 and a 😠 smiley</p>
````````````````````````````````

An emoji needs to be preceded by a space:
An emoji must not be preceded by a letter or digit:

```````````````````````````````` example
These are not:) an emoji with a:) x:angry:x
Expand All @@ -37,3 +37,45 @@ and keeps going to the next line :)
<p>This is a sentence 👌
and keeps going to the next line 😃</p>
````````````````````````````````

Emojis are rendered inside pipe table cells with surrounding spaces:

```````````````````````````````` example
| header |
|--------|
| :x: |
.
<table>
<thead>
<tr>
<th>header</th>
</tr>
</thead>
<tbody>
<tr>
<td>❌</td>
</tr>
</tbody>
</table>
````````````````````````````````

Emojis are rendered inside pipe table cells without surrounding spaces:

```````````````````````````````` example
| header |
|--------|
|:x:|
.
<table>
<thead>
<tr>
<th>header</th>
</tr>
</thead>
<tbody>
<tr>
<td>❌</td>
</tr>
</tbody>
</table>
````````````````````````````````
16 changes: 16 additions & 0 deletions src/Markdig.Tests/TestCustomEmojis.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,4 +121,20 @@ public void TestCustomEmojiValidation()
smileyToEmoji.Add("a", "c"); // "a" already exists in emojiToUnicode
Assert.Throws<ArgumentException>(() => new EmojiMapping(emojiToUnicode, smileyToEmoji));
}

[Test]
[TestCase("|test|\n|-|\n|:x:|", "<table>\n<thead>\n<tr>\n<th>test</th>\n</tr>\n</thead>\n<tbody>\n<tr>\n<td>❌</td>\n</tr>\n</tbody>\n</table>\n")]
[TestCase("|test|\n|-|\n| :x: |", "<table>\n<thead>\n<tr>\n<th>test</th>\n</tr>\n</thead>\n<tbody>\n<tr>\n<td>❌</td>\n</tr>\n</tbody>\n</table>\n")]
[TestCase("|test|\n|-|\n|1:x:|", "<table>\n<thead>\n<tr>\n<th>test</th>\n</tr>\n</thead>\n<tbody>\n<tr>\n<td>1:x:</td>\n</tr>\n</tbody>\n</table>\n")]
[TestCase("|test|\n|-|\n|w:x:y|", "<table>\n<thead>\n<tr>\n<th>test</th>\n</tr>\n</thead>\n<tbody>\n<tr>\n<td>w:x:y</td>\n</tr>\n</tbody>\n</table>\n")]
public void TestEmojiInPipeTable(string input, string expected)
{
var pipeline = new MarkdownPipelineBuilder()
.UseEmojiAndSmiley()
.UsePipeTables()
.Build();

var actual = Markdown.ToHtml(input, pipeline);
Assert.AreEqual(expected, actual);
}
}
5 changes: 3 additions & 2 deletions src/Markdig/Extensions/Emoji/EmojiParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,9 @@ public EmojiParser(EmojiMapping emojiMapping)
/// </summary>
public override bool Match(InlineProcessor processor, ref StringSlice slice)
{
// Previous char must be a space
if (!slice.PeekCharExtra(-1).IsWhiteSpaceOrZero())
// Previous char must be a space or non-alphanumeric.
var prevChar = slice.PeekCharExtra(-1);
if (char.IsLetterOrDigit(prevChar))
{
Comment thread
prozolic marked this conversation as resolved.
return false;
}
Expand Down
2 changes: 1 addition & 1 deletion src/SpecFileGen/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ public RoundtripSpec(string name, string fileName, string extensions)
new Spec("Grid Tables", "GridTableSpecs.md", "gridtables|advanced"),
new Spec("Custom Containers", "CustomContainerSpecs.md", "customcontainers+attributes|advanced"),
new Spec("Definition Lists", "DefinitionListSpecs.md", "definitionlists+attributes|advanced"),
new Spec("Emoji", "EmojiSpecs.md", "emojis|advanced+emojis"),
new Spec("Emoji", "EmojiSpecs.md", "pipetables+emojis|advanced+emojis"),
new Spec("Abbreviations", "AbbreviationSpecs.md", "abbreviations|advanced"),
new Spec("List Extras", "ListExtraSpecs.md", "listextras|advanced"),
new Spec("Math", "MathSpecs.md", "mathematics|advanced"),
Expand Down