Skip to content

[optimize] 优化CacheValue过期时间处理 #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aruato wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[optimize] 优化CacheValue过期时间处理 #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions xxl-cache-core/src/main/java/com/xxl/cache/core/cache/CacheValue.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
public class CacheValue implements Serializable {
private static final long serialVersionUID = 42L;

private static final long NONE_EXPIRATION_PERIOD = 1000L * 60 * 60 * 24 * 365 * 99;
private static final long NONE_EXPIRATION_PERIOD = -1L;

/**
* cache value
Expand All @@ -31,15 +31,18 @@ public CacheValue() {
}

public CacheValue(Object value) {
this.value = value;
this.survivalTime = NONE_EXPIRATION_PERIOD;
this.expirationTime = System.currentTimeMillis() + this.survivalTime;
this(value, NONE_EXPIRATION_PERIOD);
}

public CacheValue(Object value, long survivalTime) {
this.value = value;
this.survivalTime = survivalTime>0?survivalTime:NONE_EXPIRATION_PERIOD;
this.expirationTime = System.currentTimeMillis() + this.survivalTime;
if (survivalTime > 0) {
this.survivalTime = survivalTime;
this.expirationTime = System.currentTimeMillis() + survivalTime;
} else {
this.survivalTime = NONE_EXPIRATION_PERIOD;
this.expirationTime = NONE_EXPIRATION_PERIOD;
}
}

public Object getValue() {
Expand Down Expand Up @@ -80,7 +83,7 @@ public String toString() {
* isValid
*/
public boolean isValid() {
return System.currentTimeMillis() < expirationTime;
return this.survivalTime == NONE_EXPIRATION_PERIOD || System.currentTimeMillis() < expirationTime;
}

}