XDOCKER-87: Automatically build SOLR docker image with compose#22
XDOCKER-87: Automatically build SOLR docker image with compose#22ASHISH932 wants to merge 4 commits intoxwiki:masterfrom
Conversation
* Created solr docker image template * Edited build.gradle to use solr template
* Updated Readme.md
|
FTR: |
* Corrected the 10.11.8 sha256
* Latest greadle build
|
Note: this PR supersedes #14 |
|
This PR was discussed on matrix (https://matrix.to/#/!ikPtGZaGWtyblizzlR:matrix.xwiki.com/$1564651451225975nhSFW:matrix.org?via=matrix.xwiki.com&via=matrix.org&via=matrix.wina.be). The conclusion is:
Thanks @ASHISH932 ! |
|
ping @ASHISH932 about my last comment. Are you active on this PR? What's your plan? Thx! |
|
Currently, I'm not working on this PR but would possibly update it later. Since our conclusion is to create a docker-compose file only, so the changes would happen in README file only. So if you want to close the PR, for now, you could. |
|
I don't think the change is only a README change. See above where I mentioned:
Otherwise how do you set it in a compose file? |
|
This parameter is already exposed. We can use external solr with our container Is that what you mean ? |
Indeed, I guess it was done in a different PR. Note: The doc doesn't explain how the So I agree it's only doc that's remaining. Thx |
No description provided.