XWIKI-24269: Improvements for the link insertion dialog

[ClementEXWiki]

Jira URL

https://jira.xwiki.org/browse/XWIKI-24269 (precursor to https://jira.xwiki.org/browse/XWIKI-23865)

Changes

Description

• Improve the link insertion dialog

Clarifications

• The link editor has now been rewritten in Vue (no more React)
• The link editor is now a separate component, which can be used outside of a document editor
• The link editor now follows the user's selected design system
• Links can now be made to URLs, e-mail adresses (with prefilled message content), pages and attachments
• Some more advanced features such as anchors are listed in the UI but not supported by BlockNote yet
• Design is non-final, need to check that with Thiago
• The suggestions list is implemented manually, as various DS' autocomplete components may have various UX which can be bothersome

Screenshots & Video

Executed Tests

N/A

Expected merging strategy

• Prefers squash: Yes
• Backport on branches:
  *

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	npm/​grunt-jscs@​3.0.1
	npm/​btoa@​1.2.1
	npm/​grunt-contrib-copy@​1.0.0
	npm/​grunt-contrib-less@​3.0.0
	npm/​grunt-exec@​3.0.0
	npm/​grunt-postcss@​0.9.0
	npm/​grunt@​1.6.1
	npm/​cross-env@​7.0.3
	npm/​grunt-html@​17.0.1
	npm/​ip@​2.0.1
	npm/​grunt-contrib-clean@​2.0.1
	npm/​grunt-contrib-concat@​2.1.0
	npm/​grunt-contrib-jshint@​3.2.0
	npm/​grunt-contrib-cssmin@​5.0.0
	npm/​grunt-contrib-uglify@​5.2.2
	npm/​grunt-stylelint@​0.10.1
	npm/​autoprefixer@​9.8.8

View full report

[socket-security]

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action	Severity	Alert  (click "▶" to expand/collapse)
Warn		Critical CVE: Prototype Pollution in npm lodash CVE: GHSA-jf85-cpcp-j695 Prototype Pollution in lodash (CRITICAL) Affected versions: < 4.17.12 Patched version: 4.17.12 From: xwiki-platform-core/xwiki-platform-bootstrap/src/main/package-lock.json → npm/grunt-jscs@3.0.1 → npm/lodash@4.6.1 ℹ Read more on: This package | This alert | What is a critical CVE? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev. Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/lodash@4.6.1. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report