XWIKI-24270: Saving in the class editor sometimes shows a confirmation about unsaved changes#5397
Merged
michitux merged 2 commits intoxwiki:masterfrom Apr 20, 2026
Merged
Conversation
…n about unsaved changes * Add a submitInProgress marker to dataeditors.js to prevent the warning when submission is in progress. * Handle the Save & View button of the class editor in actionButtons.js to trigger the standard save event when it is pressed, but as a custom form specified in editclass.vm to avoid a major change to how the form is handled.
raphj
reviewed
Apr 20, 2026
…n about unsaved changes * Improve code style Co-authored-by: raphj <raphael.github@jakse.fr>
github-actions Bot
pushed a commit
that referenced
this pull request
Apr 20, 2026
…n about unsaved changes (#5397) * Add a submitInProgress marker to dataeditors.js to prevent the warning when submission is in progress. * Handle the Save & View button of the class editor in actionButtons.js to trigger the standard save event when it is pressed, but as a custom form specified in editclass.vm to avoid a major change to how the form is handled. (cherry picked from commit 1065e2f)
💔 Some backports could not be created
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-24270
Changes
Description
Clarifications
onbeforeunloaddialogs in Firefox. However, it was confirmed by a user that the dialogs were also present sometimes during actual use of the class editor.Screenshots & Video
No UI changes.
Executed Tests
Built the changed modules with the quality profile, executed ObjectEditorIT and
xwiki-platform-livedata-test-dockerwhich were failing before.Expected merging strategy