[Misc] Replace lambdas with method references (SonarCloud java:S1612)#5807
Merged
Conversation
* Convert 25 lambda expressions to equivalent method references across the store-transaction, store-filesystem, configuration-default and notifications-filters-api modules, as flagged by SonarCloud rule java:S1612. Co-Authored-By: Vincent Massol <vincent@massol.net>
vmassol
added
the
llm-agent
Claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 25 SonarCloud
java:S1612issues ("Replace this lambda with a method reference") across four modules:xwiki-platform-store-transaction(16, test code) —() -> this.testCase.run()→this.testCase::run, etc.xwiki-platform-store-filesystem(3, test code)xwiki-platform-configuration-default(3) — including qualifiedOuter.super::methodreferencesxwiki-platform-notifications-filters-api(3) —x -> x instanceof Foo→Foo.class::isInstanceand aStringValueNode::newconstructor referenceAll conversions are behaviour-preserving.
SonarCloud issues
Test plan
mvn clean installof the four modules passes (Checkstyle + Spoon included).🤖 Generated with Claude Code
Generated by Claude Code