[Misc] Remove unused code and add missing @Override annotations (SonarCloud)#5827
Open
vmassol wants to merge 1 commit into
Open
[Misc] Remove unused code and add missing @Override annotations (SonarCloud)#5827vmassol wants to merge 1 commit into
vmassol wants to merge 1 commit into
Conversation
…rCloud) Mechanical, behaviour-preserving cleanup of several SonarCloud rules across 24 modules: unused private fields (java:S1068), unused local variables and dead stores (java:S1481 / java:S1854), and missing @OverRide annotations (java:S1161). Co-Authored-By: Vincent Massol <vincent@massol.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mechanical, behaviour-preserving cleanup of several SonarCloud rules across 24 modules (40 issues fixed in 27 files):
@OverrideannotationsDetails
DocumentReference,RenderingContext,Logger/LoggerFactory,InternetAddress).newXObject(...),assertThrows(..., ...)), only theType name =prefix was stripped so the call remains a bare statement.@Override(S1161): the annotation was added above the flagged method signatures. Purely additive.No functional/behavioural change: unused code removal and annotation additions only.
A handful of remaining S1068 issues were intentionally left out because they are write-only fields assigned in multiple places (removing the declaration alone would not compile) — those need a non-mechanical change and are out of scope here.
Test plan
mvn clean install -Plegacy,snapshot -DskipTestsacross all 24 affected modules in one reactor — BUILD SUCCESS. Test sources still compile and Checkstyle passes; the changes are behaviour-preserving.Generated by Claude Code