XWIKI-24563: The URL input in the link edition picker is not keyboard focusable#5832
Open
Sereza5 wants to merge 2 commits into
Open
XWIKI-24563: The URL input in the link edition picker is not keyboard focusable#5832Sereza5 wants to merge 2 commits into
Sereza5 wants to merge 2 commits into
Conversation
… focusable * Added the logic to handle the tabindex like it used to be done when we used selectize in the back.
… focusable * Fixed the call order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-24563
Changes
Description
Clarifications
Screenshots & Video
Semi manual tests with Claude code (see comparison above made from the local instance).
Built the changes with
mvn -q clean install -pl xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war -Plegacy,snapshot -DskipTests -Dxwiki.checkstyle.skip=true -Dxwiki.revapi.skip=true -Dxwiki.surefire.captureconsole.skip=true.Ran the docker tests:
mvn clean verify -pl xwiki-platform-core/xwiki-platform-appwithinminutes/xwiki-platform-appwithinminutes-test/xwiki-platform-appwithinminutes-test-docker -Pintegration-tests,docker,legacy,snapshot -Dtest=UserClassFieldIT -DfailIfNoTests=false -Dxwiki.checkstyle.skip=true -Dxwiki.revapi.skip=true -Dxwiki.surefire.captureconsole.skip=trueThere was one fail here, but it was unrelated to the change (could reproduce it after reverting the changes from this PR).
Expected merging strategy