[Misc] Use pattern matching for instanceof in eventstream (SonarCloud java:S6201)#5838
Open
vmassol wants to merge 1 commit into
Open
[Misc] Use pattern matching for instanceof in eventstream (SonarCloud java:S6201)#5838vmassol wants to merge 1 commit into
vmassol wants to merge 1 commit into
Conversation
… java:S6201) * Replace instanceof-check-plus-cast with instanceof pattern variables across the eventstream API, default and Solr-store modules. Co-Authored-By: Vincent Massol <vincent@massol.net>
vmassol
added
the
llm-agent
Claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 32 open SonarCloud java:S6201 issues ("Replace this instanceof check and cast with 'instanceof ... '") across the
xwiki-platform-eventstreammodule.Each
instanceofcheck followed by a redundant cast is rewritten to use aninstanceofpattern variable (Java 16+), removing the explicit cast (and, where present, the redundant local variable declaration).Modules touched:
xwiki-platform-eventstream-api(14 sites, 14 files)xwiki-platform-eventstream-default(8 sites, 3 files)xwiki-platform-eventstream-store-solr(10 sites, 1 file)All 32 flagged sites were converted (0 dropped). Behaviour-preserving; the three modules build cleanly (
mvn clean install -DskipTests, which runs Checkstyle + Spoon).SonarCloud query: https://sonarcloud.io/project/issues?id=org.xwiki.platform%3Axwiki-platform&rules=java%3AS6201&issueStatuses=OPEN
Generated by Claude Code