[Misc] Use pattern matching for instanceof in search-solr (SonarCloud java:S6201)#5840
Open
vmassol wants to merge 1 commit into
Open
[Misc] Use pattern matching for instanceof in search-solr (SonarCloud java:S6201)#5840vmassol wants to merge 1 commit into
vmassol wants to merge 1 commit into
Conversation
… java:S6201) Replace instanceof-check-and-cast patterns with instanceof pattern matching in the xwiki-platform-search-solr module, as flagged by SonarCloud rule java:S6201. Co-Authored-By: Vincent Massol <vincent@massol.net>
vmassol
added
the
llm-agent
Claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
instanceof-check-and-cast patterns with Java 16+instanceofpattern matching in thexwiki-platform-search-solrmodule, as flagged by SonarCloud rule java:S6201.This fixes all 21 open
java:S6201issues in the module across 6 files:DefaultSolrUtils.java(11)SolrQueryExecutor.java(3)DefaultLinkStore.java(3)AbstractSolrMetadataExtractor.java(2)SolrIndexEventListener.java(1)SolrIndexInitializeListener.java(1)All changes are behaviour-preserving (bind a pattern variable and drop the redundant cast). Verified with
mvn clean install -DskipTests(Checkstyle + Spoon) onxwiki-platform-search-solr-apiandxwiki-platform-search-solr-query.SonarCloud issues:
https://sonarcloud.io/project/issues?id=org.xwiki.platform%3Axwiki-platform&issueStatuses=OPEN&rules=java%3AS6201&files=xwiki-platform-core%2Fxwiki-platform-search%2Fxwiki-platform-search-solrGenerated by Claude Code