[Misc] Use pattern matching for instanceof in security modules (SonarCloud java:S6201)#5843
Open
vmassol wants to merge 1 commit into
Open
[Misc] Use pattern matching for instanceof in security modules (SonarCloud java:S6201)#5843vmassol wants to merge 1 commit into
vmassol wants to merge 1 commit into
Conversation
…Cloud java:S6201) * Replace instanceof checks followed by casts with pattern matching for instanceof in xwiki-platform-security-authorization-api and xwiki-platform-security-requiredrights-default. Co-Authored-By: Vincent Massol <vincent@massol.net>
vmassol
added
the
llm-agent
Claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
instanceofchecks followed by explicit casts with pattern matching forinstanceof, as flagged by SonarCloud rule java:S6201.Fixes 20 issues across two leaf modules:
xwiki-platform-security-authorization-api(SecurityReference,DefaultAuthorizationManager,RightMap,RightSet,DefaultSecurityCache)xwiki-platform-security-requiredrights-default(RequiredRightsChangedResult,AbstractMacroBlockRequiredRightAnalyzer,ScriptMacroAnalyzer)All changes are behaviour-preserving mechanical refactorings; both modules build cleanly (
install, Checkstyle + Spoon included).SonarCloud issues: https://sonarcloud.io/project/issues?resolved=false&rules=java%3AS6201&id=org.xwiki.platform%3Axwiki-platform&tags=&issueStatuses=OPEN
Generated by Claude Code