[Misc] Use pattern matching for instanceof in extension modules (SonarCloud java:S6201)#5846
Open
vmassol wants to merge 1 commit into
Open
[Misc] Use pattern matching for instanceof in extension modules (SonarCloud java:S6201)#5846vmassol wants to merge 1 commit into
vmassol wants to merge 1 commit into
Conversation
…rCloud java:S6201) Replace instanceof checks followed by an explicit cast with instanceof pattern matching across the extension api, cluster, distribution, handler-xar and script modules. Co-Authored-By: Vincent Massol <vincent@massol.net>
vmassol
added
the
llm-agent
Claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes 28 SonarCloud
java:S6201issues ("Replace this instanceof check and cast with pattern matching for instanceof") across thexwiki-platform-extensionmodules.Each
instanceofcheck immediately followed by an explicit cast to the same type is replaced by aninstanceofpattern-matching binding (Java 16+), reusing the bound variable in place of the cast. The changes are behaviour-preserving.Modules touched (5 submodules, 15 files):
xwiki-platform-extension-apixwiki-platform-extension-clusterxwiki-platform-extension-distributionxwiki-platform-extension-handlers/xwiki-platform-extension-handler-xarxwiki-platform-extension-scriptVerification
mvn clean install(with Checkstyle/Spoon) passes for all five modules.Generated by Claude Code