[Misc] Use pattern matching for instanceof in model, user, livedata and lesscss modules (SonarCloud java:S6201)#5847
Open
vmassol wants to merge 1 commit into
Open
[Misc] Use pattern matching for instanceof in model, user, livedata and lesscss modules (SonarCloud java:S6201)#5847vmassol wants to merge 1 commit into
vmassol wants to merge 1 commit into
Conversation
…nd lesscss modules (SonarCloud java:S6201) Replace instanceof-check-and-cast patterns with instanceof pattern variables across the model-api, user-default, livedata-livetable and lesscss-default modules, as flagged by SonarCloud rule java:S6201. Co-Authored-By: Vincent Massol <vincent@massol.net>
vmassol
added
the
llm-agent
Claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
instanceofchecks followed by an explicit cast withinstanceofpattern variables (Java 16+ pattern matching), as flagged by SonarCloud rule java:S6201.This is a mechanical, behaviour-preserving cleanup covering 45 issues across four modules:
xwiki-platform-model-api— 15 issuesxwiki-platform-user-default— 11 issuesxwiki-platform-livedata-livetable— 10 issuesxwiki-platform-lesscss-default— 9 issuesEach site binds a pattern variable and drops the now-redundant cast (including the negated-guard / early-exit and
&&short-circuit shapes, and reusing existing explicit-cast locals where present). No public API changes.Verified with
mvn clean install(Checkstyle + Spoon) on the four affected modules.Generated by Claude Code