feat(framing): add cross-dimension constraints to rail framing#891
Open
mairas wants to merge 1 commit intoyaqwsx:masterfrom
Open
feat(framing): add cross-dimension constraints to rail framing#891mairas wants to merge 1 commit intoyaqwsx:masterfrom
mairas wants to merge 1 commit intoyaqwsx:masterfrom
Conversation
Add mintotalheight/maxtotalheight support to railslr and mintotalwidth/maxtotalwidth support to railstb. This allows rails to extend beyond the board area to meet manufacturer minimum panel size requirements without needing a full frame. Also fix existing typos where "raillr" was used instead of "railslr" in the framing section schema validation. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduction
See the panel below. The large connectors are HDMI connectors that clamp on the board edge, with SMT pads on both sides of the board. When panelized, top and bottom frames can't be used because that would interfere with connector insertion. To meet minimum panel dimensions for the fab house (70x70mm for JLCPCB, for example), the backbone would need to be very wide, and the HDMI connectors would hang outside of the panel area. By extending the rails instead, it is possible to create protective bumpers for the hanging connectors.
Content created with Claude Code follows.
Summary
mintotalheight/maxtotalheightsupport torailslrandmintotalwidth/maxtotalwidthsupport torailstb, allowing rails to extend beyond the board area to meet manufacturer minimum panel size requirements (e.g., JLCPCB's 70mm minimum) without needing a full frame"raillr"was used instead of"railslr"in the framing section schema validation, which meantmintotalwidth/maxtotalwidthwere silently ignored forrailslrMotivation
When using
railslrframing, there was no way to enforce a minimum panel height —mintotalheightwas only available forframe,railstb, andtightframe. This forced users to either switch to a full frame (which may conflict with overhanging components) or artificially increase backbone width to reach the required panel dimensions. The symmetric gap existed forrailstbmissingmintotalwidth.