Skip to content

fix: web theme toggle shows light/dark only, never the system icon #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
time-attack wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: web theme toggle shows light/dark only, never the system icon #703

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion plugins/web-ui/src/shell.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,10 @@ setSigninRequiredHandler((detail) => {

onExitCanvas(() => exitSplitIfActive());

if (typeof window !== "undefined" && !localStorage.getItem("theme")) {
localStorage.setItem("theme", window.matchMedia("(prefers-color-scheme: dark)").matches ? "dark" : "light");
}

export const ADMIN_BASE = (() => {
const base = ((import.meta as unknown as { env?: { BASE_URL?: string } }).env?.BASE_URL ?? "/").replace(/\/$/, "");
return base ? base.replace(/\/[^/]+$/, "/admin") : "/admin";
Expand Down Expand Up @@ -455,7 +459,7 @@ export function mountShell(): void {
<span class="avatar">${initials(appState.me?.user ?? "?")}</span>
<span class="user-name">${appState.me?.user ?? ""}</span>
</div>
<theme-toggle .includeSystem=${true} title="Color scheme: light / dark / system"></theme-toggle>
<theme-toggle .includeSystem=${false} title="Color scheme: light / dark"></theme-toggle>
<button class="icon-btn subtle" title="Sign out" aria-label="Sign out" @click=${signOut}>
${icon(LogOut, 17)}
</button>
Expand Down