fix(telegram): stop /update from looping on every restart#37
Merged
Conversation
Two root causes produced the repeated "Update available" / "Checking for
updates..." messages on each startup:
1. notifyUpdate re-sent the "Update available" message on every restart
because there was no dedup. Now it records the latest notified version
under {dataDir}/last-notified-version and skips if we've already
notified about that version.
2. selfUpdate called process.exit(0) before grammy's long-polling loop
could confirm the /update message by advancing the Telegram offset. On
restart, Telegram re-delivered /update, triggering an infinite loop.
Now the handler calls bot.stop() first — grammy's stop() commits the
offset via getUpdates({ offset, limit: 1 }) — and only then runs
selfUpdate.
yerzhansa
force-pushed
the
fix/update-notification-loop
branch
from
05bdd75 to
f17314c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two bugs caused "Update available" and "Checking for updates..." / "Updating..." to repeat on every bot startup:
Test plan