Remove experimental ERB support - #969
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes experimental ERB support from Phlex. The ERB functionality allowed defining view templates using ERB syntax, but is being removed as it was experimental.
Changes:
- Removed the
erbclass method andERBCompilerfromPhlex::SGML - Deleted the ERB test file that validated the ERB functionality
- Removed ERB usage from browser tests
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
quickdraw/erb.test.rb |
Deleted entire test file for experimental ERB support |
lib/phlex/sgml.rb |
Removed ERBCompiler constant and erb class method that enabled ERB template compilation |
browser_tests.rb |
Removed erb_snippet method definition and its usage in XSSWithStrings class |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I know, no one uses this feature.