Skip to content

configurable Storage dir #878

Open
Dariusz1989 wants to merge 2 commits into
ynput:developfrom
Dariusz1989:develop
Open

configurable Storage dir #878
Dariusz1989 wants to merge 2 commits into
ynput:developfrom
Dariusz1989:develop

Conversation

@Dariusz1989

Copy link
Copy Markdown

Hello

Description of changes

Added support for storage_dir venv.

Technical details

Just a config variable exposed so we can configure storage via venv for backend.

Copilot AI review requested due to automatic review settings March 16, 2026 14:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a configurable storage root directory (via AYON_STORAGE_DIR) so backend installer artifacts (desktop installers and dependency packages) can be stored outside the hardcoded /storage/desktop path.

Changes:

  • Introduces storage_dir in server configuration with default /storage.
  • Updates installer “desktop” directory resolution to use ayonconfig.storage_dir/desktop instead of a hardcoded path.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
ayon_server/installer/common.py Uses ayonconfig.storage_dir as the base path for desktop installers/dependency packages.
ayon_server/config/ayonconfig.py Adds storage_dir config field to be populated from AYON_STORAGE_DIR.
Comments suppressed due to low confidence (1)

ayon_server/installer/common.py:22

  • os.makedirs(directory) can still raise if the directory gets created between the isdir check and the call (race) and the current raise AyonException(...) drops the original traceback. Consider using exist_ok=True and exception chaining (... from e) so concurrent workers / retries don’t fail spuriously and debugging retains the underlying error context.
    directory = os.path.join(root, *args)
    if not os.path.isdir(directory):
        if for_writing:
            try:
                os.makedirs(directory)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +61 to +63
"Path to the storage root. "
"Desktop installers and dependency packages are expected in its "
"'desktop' subdirectory."
@MustafaJafar MustafaJafar added the community Issues and PRs coming from the community members label Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community Issues and PRs coming from the community members

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants