configurable Storage dir #878
Open
Dariusz1989 wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a configurable storage root directory (via AYON_STORAGE_DIR) so backend installer artifacts (desktop installers and dependency packages) can be stored outside the hardcoded /storage/desktop path.
Changes:
- Introduces
storage_dirin server configuration with default/storage. - Updates installer “desktop” directory resolution to use
ayonconfig.storage_dir/desktopinstead of a hardcoded path.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
ayon_server/installer/common.py |
Uses ayonconfig.storage_dir as the base path for desktop installers/dependency packages. |
ayon_server/config/ayonconfig.py |
Adds storage_dir config field to be populated from AYON_STORAGE_DIR. |
Comments suppressed due to low confidence (1)
ayon_server/installer/common.py:22
os.makedirs(directory)can still raise if the directory gets created between theisdircheck and the call (race) and the currentraise AyonException(...)drops the original traceback. Consider usingexist_ok=Trueand exception chaining (... from e) so concurrent workers / retries don’t fail spuriously and debugging retains the underlying error context.
directory = os.path.join(root, *args)
if not os.path.isdir(directory):
if for_writing:
try:
os.makedirs(directory)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+61
to
+63
| "Path to the storage root. " | ||
| "Desktop installers and dependency packages are expected in its " | ||
| "'desktop' subdirectory." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello
Description of changes
Added support for storage_dir venv.
Technical details
Just a config variable exposed so we can configure storage via venv for backend.