Client metadata#907
Conversation
| return None | ||
|
|
||
| try: | ||
| return json.load(open(client_json)) |
|
I'm not too keen on this. @antirotor I think your thoughts may weight well here. But Can't we store it in some dedicated grouped section in a pyproject? |
For me the issue with pyproject is that it is misleading as it looks like you can use it as standard pyproject.toml, but you can't.
We're using something that is known, for something else, because "it is known", but it is not the same. Just because we know that (and how it is used), we're ok-ish with that, but it is completely wrong. Especially for someone who tries to understand. Having pyproject.toml is shortcut leading to wrong assumptions.
What else would be in the pyproject.toml ? |
PR Checklist
client.json.Description of changes
Allow to define dependencies, and other possible client metadata with
client.jsoninstead ofpyproject.toml.This is a proposal. Right now we do allow to define dependencies using pyproject.toml, and we also do expect that the dependencies are defined with
tool.poetry.dependencies. That has multiple issues, we don't use poetry anymore, using pyproject.toml is misleading for developers and for IDEs as they try to define more 'pyproject.toml' metadata that either should not be defined or has no effect.Example change:
pyproject.toml
client.json
{ "dependencies": { "PyYaml": "^6" }, "runtimeDependencies": { "pillow": "^12" } }Technical details
The structure of the json is not validated -> thus defined, has to be added to documentation.
We also can't just change it and support both until all addons are changed.