Implemented check of installer Python version vs dependency package#977
Open
kalisp wants to merge 7 commits into
Open
Implemented check of installer Python version vs dependency package#977kalisp wants to merge 7 commits into
kalisp wants to merge 7 commits into
Conversation
kalisp
added
the
type: enhancement
2 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a bundle validation check intended to ensure the selected dependency package’s Python version is compatible with the selected desktop installer (launcher) Python version, and refactors installer listing logic into a shared helper.
Changes:
- Refactor
/desktop/installerslisting logic into a reusableget_installers()helper. - Add a new compatibility check in
api/bundles/check_bundle.pycomparing dependency package vs installer Python versions duringapi/bundles/check.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| api/desktop/installers.py | Refactors installer listing/filtering into get_installers() and reuses it from the route handler. |
| api/bundles/check_bundle.py | Adds dependency-package vs installer Python version validation during bundle checks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
iLLiCiTiT
reviewed
Jun 19, 2026
iLLiCiTiT
reviewed
Jun 19, 2026
| ) -> InstallerListModel: | ||
| result: list[Installer] = [] | ||
|
|
||
| if variant in ["production", "staging"]: |
Member
There was a problem hiding this comment.
Looks like dev bundles are not handled? Well, probably are because the logic didn't change, but I wonder how? 🙂
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
As Python version changes in recent installers (launchers) this adds check for compatibility of launcher and dependency package set on a bundle.
(Could be tested by triggering
api/bundles/check- requires BundleModel in body though. That could get pulled viaapi/bundlesendpoint.)