Improve the logic for Validate Unknown Nodes for readability#450
Open
moonyuet wants to merge 3 commits into
Open
Improve the logic for Validate Unknown Nodes for readability#450moonyuet wants to merge 3 commits into
moonyuet wants to merge 3 commits into
Conversation
…in validate unknown nodes
moonyuet
added
the
type: enhancement
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the guard logic in ValidateSceneUnknownNodes that decides when to skip unknown-node validation based on whether the current workfile’s extension matches the project’s ext_mapping, aiming to improve readability and avoid false positives when plugins are disabled.
Changes:
- Expanded
_is_workfile_extension_align_with_extension_mappingdocstring (added return description). - Tweaked handling of unsaved scenes to explicitly not block validation.
- Refactored the “aligned vs not aligned” decision path for skipping unknown-node validation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
This PR is to improve the logic for Validate Unknown Nodes for readability.
Additional review information
Detailed information of the changes made to the product or service, providing an in-depth description of the updates and enhancements. This can include technical information, code examples and anything else needed for the review of the PR.
Testing notes: