Implement "Open in RV" web action for published workfiles + media#78
Implement "Open in RV" web action for published workfiles + media#78BigRoy wants to merge 15 commits into
Conversation
- Opens the workfile in the context of the folder and task to ensure e.g. OCIO is set accordingly - Allows to pick rv app variant if multiple are configured - After open directly unsets the session filename to ensure user does not save into published file.
BigRoy
added
type: enhancement
BigRoy
changed the title
| return await Postgres.fetch(query, version_id, list(MEDIA_EXTENSIONS)) | ||
|
|
||
|
|
||
| async def _get_openrv_app_options( |
There was a problem hiding this comment.
This will not work with project bundles and will break apart if we change settings structure.
There was a problem hiding this comment.
This will not work with project bundles and will break apart if we change settings structure.
Any recommendation on how to do this instead?
There was a problem hiding this comment.
Again, we have to merge this ynput/ayon-applications#139 to be able to do stuff like this. We have to introduce some api for applications addon instead of knowing it't internal logic.
| folder_path, | ||
| task_name, | ||
| app_name=app, | ||
| # Used by pre_ftrackdata prelaunch hook to load on launch |
There was a problem hiding this comment.
What, pre_ftrackdata? That doesn't sound right.
There was a problem hiding this comment.
It's unfortunately? an existing prelaunch hook that I was a little bit afraid to touch see here.
But perhaps, renaming that hook itself is the best approach now.
… the form data making the form essentially repeat the questions
| p.product_base_type = 'workfile' | ||
| OR p.product_type = 'workfile' | ||
| ) | ||
| AND lower(r.name) = 'rv' |
There was a problem hiding this comment.
The action was showing for all workfile versions even those which are not having rv representaiton, which I believe should be hidden, right? The workfile from the screenshot is nuke workfile.
There was a problem hiding this comment.
Unfortunately to my understanding get_dynamic_actions does not work yet on frontend, so you can't be as granular as this to decide whether action should show or not. :(
3 participants
Changelog Description
Implement "Open RV workfile" web action for published workfiles
Additional review information
Fix #77
Fix #81
Testing notes: