Searchable graph tabs#24
Merged
Merged
Conversation
Owner
|
The scroll does not seem to work for me. |
Contributor
Author
|
I added visual color change for the search icon as you suggested. 
|
Owner
It does work.
Do you think it will better if it will have a collapse button that will toggle between this behavior and the old one? Because I think both of them has their cons and pros
|
yoavst
reviewed
Dec 7, 2025
| const tabsScrollBtn = document.getElementsByClassName("tab-expand-button")[0]; | ||
| if (!tabsScrollBtn || !this.tabsView) return; | ||
|
|
||
| console.log("Initiating tab arrow visibility controller"); |
Owner
|
Remove the console log and I'll merge |
Contributor
Author
|
Hi, I think you didn't review the latest commit. The |
Contributor
Author
|
Fixed a very minor bug. Images for fun: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added search and scroll to the tabs bar:
One problem worth mentioning - Dividers act a bit weird when in search, I didn't want to remove the option for tab dragging - so now it shows only dividers that are before visible tabs. This creates the fun problem that filtering on one item only and dragging it to it's right - sends it to the end of the list:
Also if there are two results in the search dragging the left one to the middle will clip it to the right in the real list but the other way around will do nothing.
Another thing is that I used
:not(:placeholder-shown)that according to caniuse.com has an ok-ish support:https://caniuse.com/?search=%3Aplaceholder-shown
https://caniuse.com/?search=%3Anot
I can remove then in exchange for more JS code or a less friendly UX for searching tabs.
Would be happy to change anything as needed.
Yonlif