CSS 内の小数の値はさいしょの 0 を書かない#82
Merged
Merged
Conversation
Collaborator
|
CIのFIXEDが反映されてないけどいいか |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
やったこと
#64 (comment)
のような指摘に対応するために
LeadingZeroの設定を変更しました。https://github.com/brigade/scss-lint/blob/master/lib/scss_lint/linter/README.md#leadingzero
元々この repo で使っている
.scss-lint.ymlの中身は kajaeru からもってきたものですが、当時このLeadingZeroをなんで敢えてinclude_zeroにしたのかよくわからなかったので、デフォルト設定値に戻したかたちになります 🙇https://github.com/yochiyochirb/kajaeru/pull/91/files#diff-17d88a0ede66749ec03514e034de8f73R57
対応する issue
なし