Filtering for the handlebars rank vs occurence#2373
Filtering for the handlebars rank vs occurence#2373SHIRO-Suit wants to merge 1 commit intoyomidevs:masterfrom
Conversation
Makes both average rank and harmonic rank use only rank frequencies. And average occurence and harmonic occurence use only occurence frequencies.
Kuuuube
left a comment
There was a problem hiding this comment.
This is not how handlebars changes work. You cannot change an existing upgrade file. You must create a new one, bump the overall yomitan settings version, and run a handlebars apply within that.
Also not all freq dicts have a frequencyMode in them. Can't break handling of them.
|
Ok, I agree this PR is quite extreme completely removing them if a single dictionary has this field. Is it what you meant by breaking their handling ? is it preferable to have the legacy dictionaries being counted in the calculations of both rank and occurence then? |
Fix for #2322
Makes both average rank and harmonic rank use only rank frequencies. And average occurence and harmonic occurence use only occurence frequencies.
This prevents having a 10,000 rank frequency word but appears only once in the book and being averaged at 5,000 because of that. completely thowing off anki sort feature.