ref: typescript serverless compilation#1253
Conversation
There was a problem hiding this comment.
Code Review
This pull request simplifies the serverless node setup, refactors configuration structures (including default LLM providers), and moves file-copying utilities to a shared module. The review feedback highlights several critical issues: removing #[serde(default)] from ServeConfig breaks backward compatibility by making fields mandatory; the refactored node copying logic fails if the src directory is missing (preventing app.ts from being copied); package-lock.json is no longer copied, which can lead to inconsistent dependency installations; and there is a redundant .to_string() call on api_key.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1253 +/- ##
==========================================
- Coverage 60.25% 60.22% -0.03%
==========================================
Files 46 46
Lines 10455 10460 +5
==========================================
Hits 6300 6300
- Misses 4155 4160 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
No description provided.