Skip to content

ref: typescript serverless compilation#1253

Merged
wujunzhuo merged 6 commits into
yomorun:mainfrom
wujunzhuo:ref
Jul 14, 2026
Merged

ref: typescript serverless compilation#1253
wujunzhuo merged 6 commits into
yomorun:mainfrom
wujunzhuo:ref

Conversation

@wujunzhuo

Copy link
Copy Markdown
Collaborator

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the serverless node setup, refactors configuration structures (including default LLM providers), and moves file-copying utilities to a shared module. The review feedback highlights several critical issues: removing #[serde(default)] from ServeConfig breaks backward compatibility by making fields mandatory; the refactored node copying logic fails if the src directory is missing (preventing app.ts from being copied); package-lock.json is no longer copied, which can lead to inconsistent dependency installations; and there is a redundant .to_string() call on api_key.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/serverless.rs
Comment thread src/serve_config.rs
Comment thread src/serverless.rs
Comment thread src/llm_provider/openai_compatible/mod.rs Outdated
wujunzhuo and others added 2 commits July 14, 2026 11:04
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@wujunzhuo wujunzhuo requested a review from woorui July 14, 2026 03:06
@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 84 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.22%. Comparing base (38fbedf) to head (2ce0c53).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/serve_config.rs 0.00% 28 Missing ⚠️
src/utils.rs 0.00% 25 Missing ⚠️
src/serverless.rs 0.00% 15 Missing ⚠️
src/bin/yomo.rs 0.00% 14 Missing ⚠️
src/llm_provider/openai_compatible/mod.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1253      +/-   ##
==========================================
- Coverage   60.25%   60.22%   -0.03%     
==========================================
  Files          46       46              
  Lines       10455    10460       +5     
==========================================
  Hits         6300     6300              
- Misses       4155     4160       +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wujunzhuo wujunzhuo merged commit 8146626 into yomorun:main Jul 14, 2026
2 of 3 checks passed
@wujunzhuo wujunzhuo deleted the ref branch July 14, 2026 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants