Skip to content

fix: responses schema normalization#1255

Merged
woorui merged 6 commits into
mainfrom
fix/responses-schema-normalization
Jul 14, 2026
Merged

fix: responses schema normalization#1255
woorui merged 6 commits into
mainfrom
fix/responses-schema-normalization

Conversation

@woorui

@woorui woorui commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces response streaming checks based on success status codes and adds a request body sanitization mechanism for specific GPT-5.6 models to normalize message-like inputs by ensuring they have a type field set to 'message'. The review feedback correctly points out that the current sanitization logic discards extra fields (such as id, phase, or tool-related fields) by rebuilding the message map from scratch. It is recommended to mutate the existing JSON object in-place to preserve these fields, and to update the test assertions accordingly.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/model_api_provider/providers/responses.rs Outdated
Comment thread src/model_api_provider/providers/responses.rs Outdated
@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.99248% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.75%. Comparing base (63c7020) to head (8887eac).

Files with missing lines Patch % Lines
src/model_api_provider/providers/responses.rs 96.99% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1255      +/-   ##
==========================================
+ Coverage   60.29%   60.75%   +0.46%     
==========================================
  Files          46       46              
  Lines       10476    10609     +133     
==========================================
+ Hits         6316     6445     +129     
- Misses       4160     4164       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@woorui woorui requested a review from wujunzhuo July 14, 2026 08:01
@woorui woorui self-assigned this Jul 14, 2026
@woorui woorui merged commit ca23585 into main Jul 14, 2026
6 checks passed
@woorui woorui deleted the fix/responses-schema-normalization branch July 14, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants