Reconcile Firmament V2 syntax docs and normalize V2 fixture metadata#802
Merged
yuechen-li-dev merged 1 commit intoJun 24, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
let, Forge-backed concepts, and the role of templates so future work does not invent conflicting grammar.Description
docs/v2/firmament-v2-concept-template-syntax-reconciliation.mdcontaining Phase 1 doctrine:letsemantics, concept-family application shape, template vs concept distinction, parser vs Forge responsibilities,pmikeyword guidance, canonical example, and explicit deferrals.docs/v2/aetheris-v2-phase1-scope-contract.mdwithout rewriting the contract text.fixture-id,case,category,validity,implementation,expected, andexpected-stagewhere missing in these files:concept-applications-forge.valid.firmfixture,let-arithmetic-expressions.valid.firmfixture,let-primitive-literals.valid.firmfixture,let-record-groups.valid.firmfixture,let-toleranced-values.valid.firmfixture, andpmi-record-shaped-basic.valid.firmfixture.process<CNC>,hole<Countersink>) and set parser-backed/expected-stage metadata (commonlyfeature-air) rather than changing parser or Forge logic, and treatedair-x7-firmfixture-metadata-invalidas the loader diagnostic for malformed/missing leading metadata.Testing
dotnet restore Aetheris.slnxwhich completed successfully.dotnet build Aetheris.slnx -f net10.0 --no-restore /m:1which succeeded (pre-existing compiler warnings only).dotnet test Aetheris.CLI.Tests/Aetheris.CLI.Tests.csproj -f net10.0 --filter "Help|Cli|ExitCode"which passed (275 tests).dotnet test Aetheris.Kernel.Firmament.Tests/Aetheris.Kernel.Firmament.Tests.csproj -f net10.0 --filter "Fixture|Corpus|Forge|Concept|FirmamentV2|Language"which passed (197 tests).Codex Task