Add Firmament V2 Phase 1 validation report and aetheris validate CLI#803
Merged
yuechen-li-dev merged 1 commit intoJun 24, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
firmamentV2ValidationJSON.Description
Aetheris.Kernel.Firmament/FirmamentV2/FirmamentV2ValidationReport.csthat producesFirmamentV2ValidationReportwithsource,status,lets,concepts,pmi,exportSupport,diagnostics, andsummary, and includes the Phase‑1 export matrix and deterministic status semantics (invalid,valid-with-deferred-export,valid).IsFatalDiagnosticCode(public) and change parse result wiring so the parse can preserve aDocumentwhile marking parse success/fatality; the report builder classifies diagnostics intofatal/warningand includes tolerance-drop warnings.validatecommand to the CLI inAetheris.CLI/CliRunner.csexposingdotnet run --project Aetheris.CLI -- validate <file.firmament|file.firmfixture> [--json]which emits JSON rooted atfirmamentV2Validationwhen--jsonis used.fixtures/FirmamentV2/Language/*, add unit testsAetheris.Kernel.Firmament.Tests/FirmamentV2ValidationReportTests.cs, and add documentationdocs/implementation/v2-phase1-r1-validation-report.mdand scope-contract updates.Testing
dotnet restoreanddotnet build Aetheris.slnx -f net10.0 --no-restore /m:1, which completed successfully (build warnings only).dotnet test Aetheris.Kernel.Firmament.Tests/Aetheris.Kernel.Firmament.Tests.csprojwith filters for validation/report/PMI-related tests; tests passed (targeted suite and newValidationReporttests succeeded).dotnet run --project Aetheris.CLI -- validate fixtures/FirmamentV2/Language/valid/v2-phase1-validation-report.valid.firmfixture --jsonand verified output containsfirmamentV2ValidationJSON with expectedstatus(valid-with-deferred-export) and counts.git diff --checkand repository build/test validations described above as part of the change verification.Codex Task