V2-PHASE1-P2: Export record-shaped PMI (datum, diameter) to AP242 with tolerance support#804
Merged
yuechen-li-dev merged 1 commit intoJun 24, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
pmiauthoring flow into real AP242 export so datum and diameter PMI authored over existing InlineStep models produce semantic AP242 evidence.letdimensions for diameter PMI and make unsupported PMI kinds explicit (deferred) rather than silently dropped.Description
Step242SemanticPmipipeline by enhancingBuildV2SemanticPmito include diameter tolerances from bound PMI and datum mappings.Step242Exporterasdiameter_tolerance:<featureId>withtolerance_plusandtolerance_minusMEASURE_REPRESENTATION_ITEMs.ValidateV2PmiExportSupportthat rejects build/export when export-deferred PMI records (distance, flatness, parallel, perpendicular, coplanar) are present.pmiExportEvidencetoCliRunnerand add parser/binder + export regression tests and fixtures underfixtures/FirmamentV2/InlineStep(valid primary fixture and two invalid fixtures).docs/implementation/v2-phase1-p2-record-pmi-ap242-export.mdand updatedocs/v2/aetheris-v2-phase1-scope-contract.mdstatus note.Testing
dotnet restore Aetheris.slnxanddotnet build Aetheris.slnx -f net10.0 --no-restore /m:1— build succeeded (pre-existing warnings).dotnet test Aetheris.Kernel.Firmament.Tests/... --filter "RecordPmi|PMI|Pmi|Datum|Diameter|InlineStep|AP242|FirmamentV2" --no-build— tests passed (192 tests matched).aetheris validate <fixture> --json,aetheris build <fixture> --out <tmp>.step --json, andaetheris analyze <tmp>.step --json— validation, build, export and reimport checks completed and expected AP242 evidence strings were present.dimension:lets, AP242 emission/reimport evidence, rejection of diameter without tolerance, and deterministic failure/reporting for export-deferredflatnessrecords.Codex Task