You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Added environment variable to support k8s graceful shutdown. It is not a graceful shutdown by definition.
It would be useful for running gobetween behind Google Cloud Loadbalancer. Kubernetes Engine sends syscall.SIGTERM and at the same time stop sending requests to the pod before shutdown. Because those actions are done at the same time race condition occurs and the process needs to sleep before exiting.
Please accept simple pull request.
Kubernetes Engine sends syscall.SIGTERM and at the same time stop sending requests to the pod before shutdown. Because those actions are done at the same time race condition occurs and the process needs to sleep before exiting.
Could you please clarify why the process needs to sleep before exiting? So that we make sure gobetween won't shutdown while Kubernetes still sending requests to it? And also what value should GOBETWEEN_SHUTDOWN_TIME have - are there some recommendations for those who use Google Cloud Loadbalancer?
Thanks!
Sorry for the delay in answer.
Yes, Kubernetes still sending requests to pods that are about to get deleting. SIGTERM & routing of requests happen at the same time and cause race conditions.
I am using GOBETWEEN_SHUTDOWN_TIME 20s in my production environment. It is extremely hight for safety (theoretically GKE doesn't route any requests after 1s but for safety, I set 20s in case there are long-running requests).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added environment variable to support k8s graceful shutdown. It is not a graceful shutdown by definition.
It would be useful for running gobetween behind Google Cloud Loadbalancer. Kubernetes Engine sends syscall.SIGTERM and at the same time stop sending requests to the pod before shutdown. Because those actions are done at the same time race condition occurs and the process needs to sleep before exiting.
Please accept simple pull request.