Closed
Fix SNI extraction for fragmented TLS ClientHello messages#343
Conversation
Author
|
@yyyar 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Copilot
AI
changed the title
[WIP] Fails to Detect SNI with Xray
Fix SNI extraction for fragmented TLS ClientHello messages
Aug 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the SNI (Server Name Indication) extraction issue when TLS ClientHello messages are fragmented across multiple TCP segments or TLS records, which commonly occurs with Xray proxy using Chrome fingerprints.
Problem
The original implementation in
utils/tls/sni/sni.goonly performed a singleconn.Read()call to capture the ClientHello message. When Xray uses Chrome fingerprint, the TLS handshake data can be split across multiple reads, causing the SNI extraction to fail with empty hostnames.Solution
Enhanced the
Sniff()function to handle fragmented reads by:readTLSRecords()function that continues reading until complete TLS records are availableKey Changes
Sniff()function: Now usesreadTLSRecords()instead of singleconn.Read()readTLSRecords()function: Implements intelligent buffering that:Testing
Added comprehensive tests demonstrating:
The fix maintains full backward compatibility while resolving the fragmentation issue reported with Xray Chrome fingerprints.
Fixes #342.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
example.com/tmp/go-build852115530/b001/exe/test_real_tls(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.