Skip to content

WIP Implement OrderedStream for PropertyStream - #1563

Draft
ids1024 wants to merge 1 commit into
z-galaxy:mainfrom
ids1024:ordered-property-stream
Draft

WIP Implement OrderedStream for PropertyStream#1563
ids1024 wants to merge 1 commit into
z-galaxy:mainfrom
ids1024:ordered-property-stream

Conversation

@ids1024

@ids1024 ids1024 commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

This seems like it could be useful. The behavior of an ordered stream may bit a little odd in what it does and does not guarantee with the behavior of dropping intermediate values that PropertyStream has, but I believe this can still be useful. This looks like it also applies to NameOwnerChangedStream, which is already an OwnedStream.

I think this approach should work, but there are a few details that still need fixing, and I need to test it. But it seems good to create a PR rather than just leave this sitting in my git stash.

This seems like it could be useful. The behavior of an ordered stream
may bit a little odd in what it does and does not guarantee with the
behavior of dropping intermediate values that `PropertyStream` has, but
I believe this can still be useful. This looks like it also applies to
`NameOwnerChangedStream`, which is already an `OwnedStream`.

I think this approach should work, but there are a few details that
still need fixing, and I need to test it. But it seems good to create a
PR rather than just leave this sitting in my git stash.
@codspeed-hq

codspeed-hq Bot commented Nov 4, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #1563 will improve performances by 38.47%

Comparing ids1024:ordered-property-stream (5318cfd) with main (454c11e)

Summary

⚡ 5 improvements
✅ 17 untouched

Benchmarks breakdown

Benchmark BASE HEAD Change
unique 1.8 µs 1.5 µs +16.52%
big_array_and_ass_dict_ser 6.4 ms 5.3 ms +21.61%
big_array_and_asv_dict_ser 11.6 ms 10.3 ms +12.24%
big_array_ser 2.7 ms 2.3 ms +20.19%
fixed_size_array_ser 4.6 ms 3.3 ms +38.47%

@zeenix

zeenix commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

@danieldg This would be something you'd be the best person to review.

@zeenix

zeenix commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

@ids1024 would you be finishing this?

@zeenix

zeenix commented May 25, 2026

Copy link
Copy Markdown
Contributor

@ids1024 it's been several months since my last ping. Please close this if you don't intend to finish it, at least. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants