WIP Implement OrderedStream for PropertyStream - #1563
Draft
ids1024 wants to merge 1 commit into
Draft
Conversation
This seems like it could be useful. The behavior of an ordered stream may bit a little odd in what it does and does not guarantee with the behavior of dropping intermediate values that `PropertyStream` has, but I believe this can still be useful. This looks like it also applies to `NameOwnerChangedStream`, which is already an `OwnedStream`. I think this approach should work, but there are a few details that still need fixing, and I need to test it. But it seems good to create a PR rather than just leave this sitting in my git stash.
CodSpeed Performance ReportMerging #1563 will improve performances by 38.47%Comparing Summary
Benchmarks breakdown
|
Contributor
|
@danieldg This would be something you'd be the best person to review. |
Contributor
|
@ids1024 would you be finishing this? |
Contributor
|
@ids1024 it's been several months since my last ping. Please close this if you don't intend to finish it, at least. 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems like it could be useful. The behavior of an ordered stream may bit a little odd in what it does and does not guarantee with the behavior of dropping intermediate values that
PropertyStreamhas, but I believe this can still be useful. This looks like it also applies toNameOwnerChangedStream, which is already anOwnedStream.I think this approach should work, but there are a few details that still need fixing, and I need to test it. But it seems good to create a PR rather than just leave this sitting in my git stash.