Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the project version to 0.5.1 and configures the root package to bundle @scrolloop/core and @scrolloop/shared using tsup. Feedback suggests moving these bundled workspace packages from dependencies to devDependencies to avoid redundant installations for consumers, as they are already included in the build output.
| "dependencies": { | ||
| "@scrolloop/core": "workspace:*", | ||
| "@scrolloop/shared": "workspace:*" | ||
| } |
There was a problem hiding this comment.
Since @scrolloop/core and @scrolloop/shared are configured to be bundled into the build output (as indicated by the noExternal setting in tsup.config.ts), they should be moved to devDependencies. Listing them in dependencies will cause them to be installed as separate runtime packages by consumers, which is redundant and increases the installation footprint unnecessarily when the code is already included in the bundle.
📊 Test Coverage Report (vitest)
|
1 participant
No description provided.