fix: implement ConfigDiscoveryHook for PrometheusOverride to enable OPA status metrics#3851
Draft
x418 wants to merge 1 commit intozalando:masterfrom
Draft
fix: implement ConfigDiscoveryHook for PrometheusOverride to enable OPA status metrics#3851x418 wants to merge 1 commit intozalando:masterfrom
x418 wants to merge 1 commit intozalando:masterfrom
Conversation
…PA status metrics ## What & Why? Implement ConfigDiscoveryHook.OnConfigDiscovery() for PrometheusOverride to enable Prometheus status metrics when using discovery bundles. zalando#3631 added support to also expose native OPA metrics via Skipper's metrics endpoint. This PR extends it by also ensuring that we also enable it when using discovery bundles Signed-off-by: Santhosh Kannan <29794224+x418@users.noreply.github.com>
|
Cannot start a pipeline due to: Click on pipeline status check Details link below for more information. |
x418
changed the title
Collaborator
|
@x418 is this still relevant? Looks like a good approach to capture more metrics that already exist. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & Why?
Implement ConfigDiscoveryHook.OnConfigDiscovery() for PrometheusOverride to enable Prometheus status metrics when using discovery bundles.
#3631 added support to also expose native OPA metrics via Skipper's metrics endpoint. This PR extends it by also ensuring that we also enable it when using discovery bundles
TODO: Extract some reusable methods if this is the way we want to go