docs: stronger warning that tests don't run against Sepolia#6
Merged
Conversation
Replace the inline note with a GitHub [!WARNING] admonition placed between the local-deploy and Sepolia-deploy steps, with concrete failing examples for both forge test and forge script. The warning is the natural place to disambiguate: you *can* deploy to Sepolia (next step), but you cannot test or decrypt against it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Builds on the previous README note (#5) per review feedback:
[!WARNING]admonition with a 🚧 emoji so it visually breaks out of the regular flow.❌ FAILexamples for bothforge testandforge scriptagainst a Sepolia RPC — the most likely incorrect commands a new user would try.Test plan
[!WARNING]admonition renders on the GitHub PR view (rendering can be sensitive to placement inside numbered lists — placed at column 0 here so step 4 still numbers correctly)