|
1 | 1 | ## Test environments |
2 | 2 | * local Windows 11, R 4.5.2 |
3 | 3 | * GitHub Actions: |
4 | | - * macOS (arm64 and x86_64) — R devel, release, oldrel-1 (total 6 runners) |
5 | | - * Windows (arm64 and x86_64) — R devel, release, oldrel-1 (total 6 runners) |
6 | | - * Linux (x86_64 and arm64) — R devel, release, patched, oldrel-1 (total 5 runners) |
7 | | -* win-builder (devel and release) |
| 4 | + * macOS (arm64 and x86_64) — R devel, release, oldrel-1 (6 runners) |
| 5 | + * Windows (arm64 and x86_64) — R devel, release, oldrel-1 (6 runners) |
| 6 | + * Linux (x86_64 and arm64) — R devel, release, patched, oldrel-1 (5 runners) |
| 7 | +* win-builder (devel, release, and oldrelease) |
| 8 | +* R-hub (Fedora Linux, Ubuntu Linux with ASAN/UBSAN/Valgrind, macOS-arm64) |
8 | 9 |
|
9 | 10 | ## R CMD check results |
10 | 11 | 0 errors | 0 warnings | 1 note |
11 | 12 |
|
12 | | -* NOTE: Installed package size is 9.2Mb. |
13 | | - The installed size is primarily driven by the `libs` directory (~8.0Mb) due to `RcppEigen`-based C++ code. |
| 13 | +* NOTE: Installed package size is 9.2Mb. |
| 14 | + The size is driven by the compiled `libs` directory (~8.0Mb) required for high-performance `RcppEigen` matrix operations. |
14 | 15 |
|
15 | 16 | ## Submission Summary |
16 | 17 | This is a resubmission to address CRAN check findings from version 2.0.0. |
17 | 18 |
|
18 | | -Changes made: |
19 | | -* Fixed macOS ARM64 test error (`invalid comparison with complex values`) in `ppg_esim` by using `Re()` on eigenvalues before rank checks. |
20 | | -* Removed non-portable `.mhtml` files and updated `.Rbuildignore` to exclude development log files (`.txt`, `.mhtml`). |
21 | | -* Updated string-matching tests to use explicit matching (`fixed = TRUE` or `perl = TRUE`) and kept `skip_on_cran()` in CRAN-sensitive heavy/error-handling tests. |
22 | | -* Removed unused C++ variable in `src/math_primitives.cpp` (`min_group`) to resolve strict compiler warning checks. |
23 | | -* Corrected test setup in `tests/testthat/test-design_stats.R` for invalid `design_type` test input initialization. |
| 19 | +### Major Fixes: |
| 20 | +* **macOS ARM64:** Resolved the `invalid comparison with complex values` error in `ppg_esim`. Calculations now use strict real-part extraction via `Re()` on eigenvalues prior to rank/comparison checks, ensuring architectural parity between Intel and Apple Silicon. |
| 21 | +* **Memory Sanitizers (gcc-san):** Addressed the `runtime error: signed integer overflow` reported in `tests/testthat.Rout`. This was identified as a known issue in the Base R TRE regular expression engine (`tre-match-approx.c`). To ensure clean CRAN runs, affected string-matching tests now use `fixed = TRUE` or `perl = TRUE`, and `skip_on_cran()` is utilized for heavy error-handling tests. |
| 22 | +* **Compiler Warnings:** Fixed a strict compiler warning in `src/math_primitives.cpp` by removing an unused variable (`min_group`). |
| 23 | +* **rchk:** All reports were reviewed. Identified reports reference internal `Rcpp` headers (`Armor.h`/`Shield.h`); no memory-protection issues exist in the package source code. |
24 | 24 |
|
25 | | -rchk note: |
26 | | -* Reports referencing `Rcpp` internal headers (`Armor.h` / `Shield.h`) were reviewed; no corresponding memory-protection issue was identified in package source files. |
| 25 | +### Logistical Fixes: |
| 26 | +* Removed non-portable `.mhtml` and `.txt` files from the source. |
| 27 | +* Updated `.Rbuildignore` to ensure a clean root directory. |
| 28 | +* Corrected test initialization in `tests/testthat/test-design_stats.R`. |
0 commit comments