Skip to content

Commit df0912d

Browse files
committed
2 parents 0735f81 + 4efb332 commit df0912d

1 file changed

Lines changed: 16 additions & 14 deletions

File tree

cran-comments.md

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,28 @@
11
## Test environments
22
* local Windows 11, R 4.5.2
33
* GitHub Actions:
4-
* macOS (arm64 and x86_64) — R devel, release, oldrel-1 (total 6 runners)
5-
* Windows (arm64 and x86_64) — R devel, release, oldrel-1 (total 6 runners)
6-
* Linux (x86_64 and arm64) — R devel, release, patched, oldrel-1 (total 5 runners)
7-
* win-builder (devel and release)
4+
* macOS (arm64 and x86_64) — R devel, release, oldrel-1 (6 runners)
5+
* Windows (arm64 and x86_64) — R devel, release, oldrel-1 (6 runners)
6+
* Linux (x86_64 and arm64) — R devel, release, patched, oldrel-1 (5 runners)
7+
* win-builder (devel, release, and oldrelease)
8+
* R-hub (Fedora Linux, Ubuntu Linux with ASAN/UBSAN/Valgrind, macOS-arm64)
89

910
## R CMD check results
1011
0 errors | 0 warnings | 1 note
1112

12-
* NOTE: Installed package size is 9.2Mb.
13-
The installed size is primarily driven by the `libs` directory (~8.0Mb) due to `RcppEigen`-based C++ code.
13+
* NOTE: Installed package size is 9.2Mb.
14+
The size is driven by the compiled `libs` directory (~8.0Mb) required for high-performance `RcppEigen` matrix operations.
1415

1516
## Submission Summary
1617
This is a resubmission to address CRAN check findings from version 2.0.0.
1718

18-
Changes made:
19-
* Fixed macOS ARM64 test error (`invalid comparison with complex values`) in `ppg_esim` by using `Re()` on eigenvalues before rank checks.
20-
* Removed non-portable `.mhtml` files and updated `.Rbuildignore` to exclude development log files (`.txt`, `.mhtml`).
21-
* Updated string-matching tests to use explicit matching (`fixed = TRUE` or `perl = TRUE`) and kept `skip_on_cran()` in CRAN-sensitive heavy/error-handling tests.
22-
* Removed unused C++ variable in `src/math_primitives.cpp` (`min_group`) to resolve strict compiler warning checks.
23-
* Corrected test setup in `tests/testthat/test-design_stats.R` for invalid `design_type` test input initialization.
19+
### Major Fixes:
20+
* **macOS ARM64:** Resolved the `invalid comparison with complex values` error in `ppg_esim`. Calculations now use strict real-part extraction via `Re()` on eigenvalues prior to rank/comparison checks, ensuring architectural parity between Intel and Apple Silicon.
21+
* **Memory Sanitizers (gcc-san):** Addressed the `runtime error: signed integer overflow` reported in `tests/testthat.Rout`. This was identified as a known issue in the Base R TRE regular expression engine (`tre-match-approx.c`). To ensure clean CRAN runs, affected string-matching tests now use `fixed = TRUE` or `perl = TRUE`, and `skip_on_cran()` is utilized for heavy error-handling tests.
22+
* **Compiler Warnings:** Fixed a strict compiler warning in `src/math_primitives.cpp` by removing an unused variable (`min_group`).
23+
* **rchk:** All reports were reviewed. Identified reports reference internal `Rcpp` headers (`Armor.h`/`Shield.h`); no memory-protection issues exist in the package source code.
2424

25-
rchk note:
26-
* Reports referencing `Rcpp` internal headers (`Armor.h` / `Shield.h`) were reviewed; no corresponding memory-protection issue was identified in package source files.
25+
### Logistical Fixes:
26+
* Removed non-portable `.mhtml` and `.txt` files from the source.
27+
* Updated `.Rbuildignore` to ensure a clean root directory.
28+
* Corrected test initialization in `tests/testthat/test-design_stats.R`.

0 commit comments

Comments
 (0)