grpc: replace manual protobuf wire parsing - #7483
Draft
kingthorin wants to merge 2 commits into
Draft
Conversation
Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
Completes the wire parsing refactor by adding the ZAP text format codec and bytes-to-text-to-bytes coverage referenced by the decoder and encoder.
kingthorin
force-pushed
the
grpc-new-parse
branch
from
June 24, 2026 15:42
6789b89 to
550cafe
Compare
Member
|
Great job! No new security vulnerabilities introduced in this pull requestUse @Checkmarx to interact with Checkmarx PR Assistant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace hand-rolled protobuf wire parsing in the gRPC add-on with
protobuf-java(UnknownFieldSet) behind aZapProtoTextCodecadapter. The gRPC message views and variant keep the same editable text format and behaviour; corrupted payloads now fail cleanly instead of showing partial fields.grpc-protobufin favour ofprotobuf-javaProtoBufNestedMessageDecoderand ~400 lines of manual encode/decode logicWhy / future work
Centralises protobuf handling in one codec layer on a maintained library API. That gives a stable base for later schema-aware decoding (e.g. gRPC reflection +
DynamicMessage) while keeping the current schema-less path as fallback.Related Issues