d_a_obj_kanoke 100% matching - #1151
Open
K1ngst0m wants to merge 3 commits into
Open
Conversation
Report for GZLE01 (2289b54 - 578ef46)📈 Matched code: 73.53% (+0.11%, +8696 bytes) ✅ 60 new matches
...and 30 more new matches Report for GZLJ01 (2289b54 - 578ef46)📈 Matched code: 72.23% (+0.11%, +8692 bytes) ✅ 60 new matches
...and 30 more new matches Report for GZLP01 (2289b54 - 578ef46)📈 Matched code: 71.81% (+0.11%, +8696 bytes) ✅ 60 new matches
...and 30 more new matches Report for D44J01 (2289b54 - 578ef46)📈 Matched code: 66.25% (+0.11%, +8660 bytes) ✅ 60 new matches
...and 30 more new matches |
|
Nice work on d_a_obj_kanoke — verified 100% per-function matching, CI green on all four builds, and the res/SE/particle enums all check out. Two optional nits:
Neither blocks the merge. |
Collaborator
|
If you want to know why these AI-generated comments are unhelpful:
|
|
sorry i wasn't aware that it is making comments, won't happen again
في الأربعاء، 12 أغسطس 2026 في 5:43 م تمت كتابة ما يلي بواسطة Jasper St.
Pierre ***@***.***>:
… *magcius* left a comment (zeldaret/tww#1151)
<#1151 (comment)>
If you want to know why these AI-generated comments are unhelpful:
1. The names daObjKanoke_Yoko_pfs and daObjKanoke_Tate_pfs come from
the original game maps. They do not break convention.
2. This is absolutely unbelievable. The loop *already* has a comment
to explain it; you included it in your comment.
—
Reply to this email directly, view it on GitHub
<#1151?email_source=notifications&email_token=BCESLLQAOB2R52DB3YCZSC35JR7BBA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMRWHAZTKNZWGQ42M4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-5268357649>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BCESLLWP7WVEZUXO4HJX45T5JR7BBAVCNFSNUABFKJSXA33TNF2G64TZHM3DQOJTGQZTSMBVHNEXG43VMU5TKMJSG44TEOBTGI4KC5QC>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/BCESLLXDQDTOQBRGUD34UQD5JR7BBA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMRWHAZTKNZWGQ42M4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJKTGN5XXIZLSL5UW64Y>
and Android
<https://github.com/notifications/mobile/android/BCESLLSE3YMPYXKLZ35SPNT5JR7BBA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMRWHAZTKNZWGQ42M4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
Download it today!
You are receiving this because you commented.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decompiles
d_a_obj_kanoke(Earth Temple coffin,MKanoke/MKanoK2) to100% matching.